Code Refactoring

Activity 1.34.1.

There is a copy of the following code block in an interactive mode that you can modify and compile. Your task is to improve the code’s style as an expert would view it, while ensuring its behavior remains unchanged. You may run your refactored code to verify that it still passes all test cases.

public class Positive {
	public static boolean isPositive(int number) {
		if (number > 0) {
		    return true;
		} else {
		    return false;
		}
	}
}

public class Positive {
	public static boolean isPositive(int number) {
		if (number > 0) {
		    return true;
		} else {
		    return false;
		}
	}
}
====
      import static org.junit.Assert.*;
import org.junit.Test;
import java.io.*;
import org.junit.Before;
import org.junit.After;
import java.io.ByteArrayOutputStream;
import java.io.PrintStream;

public class RunestoneTests extends CodeTestHelper {

public RunestoneTests() {
	  super("Positive");
  }

// Test for positive number
  @Test
  public void testPositive() throws IOException {
	  Object[] args = {10};  // Arguments for the method
	  String output = getMethodOutput("isPositive", args);
	  String expect = Boolean.toString(true);  // Convert expected boolean to String
	  
	  // No need to manually convert the result as the output is already a string
	  boolean passed = getResults(expect, output, "isPositive(10)");
	  assertTrue(passed);
  }

// Test for zero
  @Test
  public void testZero() throws IOException {
	  Object[] args = {0};  // Arguments for the method
	  String output = getMethodOutput("isPositive", args);
	  String expect = Boolean.toString(false);  // Convert expected boolean to String
	  
	  boolean passed = getResults(expect, output, "isPositive(0)");
	  assertTrue(passed);
  }

// Test for negative number
  @Test
  public void testNegative() throws IOException {
	  Object[] args = {-2};  // Arguments for the method
	  String output = getMethodOutput("isPositive", args);
	  String expect = Boolean.toString(false);  // Convert expected boolean to String
	  
	  boolean passed = getResults(expect, output, "isPositive(-2)");
	  assertTrue(passed);
  }

}

Activity 1.34.2.

Which of the following code blocks is the most similar to your final refactored code for the previous question?

public class Positive {
	public static boolean isPositive(int number) {
		if (number > 0) {
			return true;
		} 
		return false;
	}
}

This code can further be improved!

public class Positive {
	public static boolean isPositive(int number) {
		return number > 0;
	}
}

You refactored correctly!

Section 1.34 Code Refactoring

Activity 1.34.1.

Activity 1.34.2.