Code Refactoring

Activity 1.17.1.

There is a copy of the following code block in an interactive mode that you can modify and compile. Your task is to improve the code’s style as an expert would view it, while ensuring its behavior remains unchanged. You may run your refactored code to verify that it still passes all test cases.

public class DiscountChecker {
  public static String determineDiscountEligibility(int age, int membershipYears) {
    if (age > 18) { 
      if (membershipYears >= 5) {
        return "Eligible";
      }	
    }  
    return "Not eligible";
  }
}

public class DiscountChecker {
  public static String determineDiscountEligibility(int age, int membershipYears) {
    if (age > 18) { 
      if (membershipYears >= 5) {
        return "Eligible";
      }
    }  
    return "Not eligible";
  }
}
====
import static org.junit.Assert.*;
		import org.junit.Test;
		import java.io.*;
		import org.junit.Before;
		import org.junit.After;
		import java.io.ByteArrayOutputStream;
		import java.io.PrintStream;

public class RunestoneTests extends CodeTestHelper {

public RunestoneTests() {
              super("DiscountChecker");
          }

// Test for Eligible case
          @Test
          public void testEligible() throws IOException {
              Object[] args = {20, 6};  // Arguments for the method
              String output = getMethodOutput("determineDiscountEligibility", args);
              String expect = "Eligible";
              
              boolean passed = getResults(expect, output, "determineDiscountEligibility(20, 6)");
              assertTrue(passed);
          }

// Test for Not eligible due to age
          @Test
          public void testNotEligibleDueToAge() throws IOException {
              Object[] args = {17, 6};  // Arguments for the method
              String output = getMethodOutput("determineDiscountEligibility", args);
              String expect = "Not eligible";
              
              boolean passed = getResults(expect, output, "determineDiscountEligibility(17, 6)");
              assertTrue(passed);
          }

// Test for Not eligible due to membership years
          @Test
          public void testNotEligibleDueToMembershipYears() throws IOException {
              Object[] args = {25, 3};  // Arguments for the method
              String output = getMethodOutput("determineDiscountEligibility", args);
              String expect = "Not eligible";
              
              boolean passed = getResults(expect, output, "determineDiscountEligibility(25, 3)");
              assertTrue(passed);
          }

// Test for Not eligible due to both conditions
          @Test
          public void testNotEligibleForBoth() throws IOException {
              Object[] args = {16, 2};  // Arguments for the method
              String output = getMethodOutput("determineDiscountEligibility", args);
              String expect = "Not eligible";
              
              boolean passed = getResults(expect, output, "determineDiscountEligibility(16, 2)");
              assertTrue(passed);
          }
        }

Activity 1.17.2.

Which of the following code blocks is the most similar to your final refactored code for the previous question?

public class DiscountChecker {
   public static String determineDiscountEligibility(int age, int membershipYears) {
      if (age > 18 && membershipYears >= 5) {
            return "Eligible";	
      }  
      return "Not eligible";
   }
}

You refactored correctly!

public class DiscountChecker {
   public static String determineDiscountEligibility(int age, int membershipYears) {
      if (age > 18 || membershipYears >= 5) {
            return "Eligible";	
      }  
      return "Not eligible";
   }
}

The code doesn’t have the same functionality with the original one.

public class DiscountChecker {
   public static String determineDiscountEligibility(int age, int membershipYears) {
      if (age <= 18 || membershipYears < 5) {
            return "Not eligible";	
      }  
      return "Eligible";
   }
}

You refactored correctly!

Section 1.17 Code Refactoring

Activity 1.17.1.

Activity 1.17.2.